New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify the locale used to format evaluated expressions #929

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
2 participants
@fleger
Contributor

fleger commented Jun 1, 2016

This patch allows the user to specify which locale to use when formatting the result of a ${= =} expression.
The locale can be specified by setting the FORMAT_LOCALE variable, i. e. !define FORMAT_LOCALE {fr} will make the formatting use the French locale regardless of the JVM default locale.
If the FORMAT_LOCALE variable is not defined, the default JVM locale is used.

@fleger fleger changed the title from Add ability to control the locale used to format evaluated expressions to Add ability to specify the locale used to format evaluated expressions Jun 1, 2016

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar Jun 12, 2016

Collaborator

I like this patch. I'm wondering if there are more places where localization might be desired.

Is the locale setting also desired when parsing expressions? In that case the variable can be named LOCALE.

Collaborator

amolenaar commented Jun 12, 2016

I like this patch. I'm wondering if there are more places where localization might be desired.

Is the locale setting also desired when parsing expressions? In that case the variable can be named LOCALE.

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar Jun 16, 2016

Collaborator

I think it's fine to merge now and extend localization later on.

Collaborator

amolenaar commented Jun 16, 2016

I think it's fine to merge now and extend localization later on.

@amolenaar amolenaar added this to the Next Release milestone Jun 16, 2016

@amolenaar amolenaar merged commit e68cde5 into unclebob:master Jun 16, 2016

amolenaar added a commit that referenced this pull request Jun 16, 2016

Merge pull request #929 from Enovea/master
Add ability to specify the locale used to format evaluated expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment