New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CachedInteraction fix #973

Merged
merged 23 commits into from Oct 9, 2016

Conversation

Projects
None yet
3 participants
@fhoeben
Contributor

fhoeben commented Sep 14, 2016

Fix for #972, and some initial tests for CachedInteraction

@fhoeben

This comment has been minimized.

Show comment
Hide comment
@fhoeben

fhoeben Sep 14, 2016

Contributor

@LudovicVa Did I miss something regarding CachedInteraction, or am I indeed fixing it?

Contributor

fhoeben commented Sep 14, 2016

@LudovicVa Did I miss something regarding CachedInteraction, or am I indeed fixing it?

fhoeben added some commits Sep 14, 2016

Extract constructor key generation to separate method, and use simple…
… string concatenation (which compiler will optimize) instead of string formatting
Allow subclasses of CachedInteraction (actually all subclasses of Def…
…aultInteraction) to select the method to be invoked based on the actual instance and not only on the instance's class
Allow subclasses of CachedInteraction (actually all subclasses of Def…
…aultInteraction) to select the method to be invoked based on the actual parameters and not just the number of parameters (similar to what is done for constructors)
@LudovicVa

This comment has been minimized.

Show comment
Hide comment
@LudovicVa

LudovicVa Sep 23, 2016

Contributor

I think you did fix it !! My bad...

Contributor

LudovicVa commented Sep 23, 2016

I think you did fix it !! My bad...

@amolenaar amolenaar added this to the Next Release milestone Sep 28, 2016

@amolenaar amolenaar merged commit 4cd2741 into unclebob:master Oct 9, 2016

amolenaar added a commit that referenced this pull request Oct 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment