GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #972, and some initial tests for CachedInteraction
Add test to show CachedInteraction cannot be created
Fix creation of CachedInteraction and add tests to ensure its behavio…
…r is hit (could use better assertions for cache hit/miss)
Add some whitespace
Add test for class that can not be found
@LudovicVa Did I miss something regarding CachedInteraction, or am I indeed fixing it?
Ensure cache actually works
move private class to bottom of file
integer compare before String.equals() as I expect it to be faster
Ensure method cache miss is also cached
Move private static NonExisting class to bottom of file
Remove unneeded this.
Remove unneeded import
Optimized MethodKey implementation
Same use of local variables when finding class as used for constructo…
…rs and methods
Extract constructor key generation to separate method, and use simple…
… string concatenation (which compiler will optimize) instead of string formatting
Allow subclasses of CachedInteraction (actually all subclasses of Def…
…aultInteraction) to select the method to be invoked based on the actual instance and not only on the instance's class
…aultInteraction) to select the method to be invoked based on the actual parameters and not just the number of parameters (similar to what is done for constructors)
I do not see why calling the same method twice should render a differ…
…ent result the second time...
Single location to define how to create an interaction
Remove non-test method only used in tests (in 2 places)
Make test more robust
Ensure no cache hit for method of different class, just if their simp…
…le name and method name matches
I think you did fix it !! My bad...
Merge pull request #973 from fhoeben/CachedInteractionFix