New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding for pipe based socket #997

Merged
merged 2 commits into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@amolenaar
Collaborator

amolenaar commented Dec 4, 2016

Should fix #989 and #995.

@amolenaar

This comment has been minimized.

Collaborator

amolenaar commented Dec 4, 2016

I have tried testing it on my Windows XP VM, but I can not reproduce the errors stated in #989.

I noticed, however, that the output streams on the Slim side do not apply the proper encoding (=UTF-8).

This PR should fix that. I hope someone can verify that (@fhoeben, @keetron)?

@fhoeben

This comment has been minimized.

Contributor

fhoeben commented Dec 4, 2016

Unfortunately that does not fix the issue #989 on Windows 7.
It does fix the stack trace I encountered in the console on Windows 10, running Slim's multi-byte tests.

@amolenaar

This comment has been minimized.

Collaborator

amolenaar commented Dec 4, 2016

:(

@amolenaar amolenaar merged commit c836bbf into unclebob:master Jan 23, 2017

@amolenaar

This comment has been minimized.

Collaborator

amolenaar commented Jan 23, 2017

Figured this change wouldn't hurt anyway.

@amolenaar amolenaar deleted the amolenaar:pipe-encoding branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment