ANSI compatibility fix and some language. #33

Merged
merged 2 commits into from Jan 10, 2012

Conversation

Projects
None yet
3 participants
Contributor

miiihi commented Jan 10, 2012

23724ed introduced ANSI incompatibility... Please watch for these in future...

unclecheese merged commit 1051f2d into unclecheese:master Jan 10, 2012

@mmichelli mmichelli commented on the diff Jan 12, 2012

code/ManyManyDataObjectManager.php
@@ -202,7 +202,7 @@ function ExtraData() {
function getSelectedIDs() {
$ids = array();
$dataQuery = $this->getQuery();
- $dataQuery->having("Checked = '1'");
@mmichelli

mmichelli Jan 12, 2012

This breaks ManyManyDataObjectManager fields. When I change it back to "$dataQuery->having("Checked = '1'");" they all work again.

@miiihi

miiihi Jan 12, 2012

Contributor

Well yes, this is exactly what this patch does - changes 'having' to 'where'. What's your point?

@mmichelli

mmichelli Jan 12, 2012

I wrote "where" instead of having, sorry.

My point is that after I pulled these changes my ManyManyDataObjectManager fields produce errors, so that any page with a ManyManyDataObjectManager field can not be edited.

@miiihi

miiihi Jan 12, 2012

Contributor

I apologize, my quickfix was a bit to quick. Now done properly and tested, see #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment