Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bugfix branch #40

Merged
merged 2 commits into from

2 participants

@lingo

Hi there, a couple of minor fixes here.

Renaming of files didn't update the Title attribute, which means they later show up with the old name in TreeDropdownList etc. Here I change the title, only if the old title was same as old name, hence preserving any customisations made to Title separately.

Plus, images with a space in the name weren't showing up in the attachment field correctly.

Kickassets has a lot of promise, it's a great module.

Cheers, - Luke

@unclecheese unclecheese merged commit 9512c8f into unclecheese:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
4 code/KickAssetAdmin.php
@@ -285,6 +285,10 @@ public function newfolder(SS_HTTPRequest $r) {
*/
public function updatefilename(SS_HTTPRequest $r) {
if($file = DataObject::get_by_id("File", (int) $r->requestVar('fileid'))) {
+ if ($file->Title == $file->Name) {
+ // Make sure title also changes, if old title was same as old Name.
+ $file->Title = $r->requestVar('new');
+ }
$file->setName($r->requestVar('new'));
$file->write();
$template = $file instanceof Folder ? "Folder" : "File";
View
2  templates/Includes/KickAssetFieldFiles.ss
@@ -2,7 +2,7 @@
<div class="file_drop <% if File %><% else %>empty<% end_if %>" data-uploadurl="$UploadLink"
<% if File %>
<% control File %>
- style="background-image:url($Thumb)"
+ style="background-image:url('$Thumb')"
<% end_control %>
<% end_if %>
>
Something went wrong with that request. Please try again.