New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tellraw console commands vs message to player #286

Open
uncovery opened this Issue Mar 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@uncovery
Owner

uncovery commented Mar 27, 2017

Websend needs to be fixed so that this differenciation here can be solved:

https://github.com/uncovery/uncovery_me/blob/master/includes/websend.inc.php#L702

Issue: The 2 PrintTo functions do not work with NBT/JSON formatted text. (PrintToConsole & PrintToPlayer).
In other words, once text is parse through umc_text_format (https://github.com/uncovery/uncovery_me/blob/master/includes/websend.inc.php#L563), the formatting code is shown unprocessed to the recipient of the message.

Solution options:

  1. Through looking at the websend code, we come to the conclusion that it is recommended that we use the PrintTo commands in a way that they understand NBT/JSON formats and fix websend accordingly.

  2. If, by looking at the code, we come to the conclusion that the PrintTo functions should not be modified or are not able to process formatted text, we need to continue using /Command/ExecuteConsoleCommand:tellraw for in-game user commands and filter the NBT format out for PrintToConsole so that console receives legacy-style data

In any case, some of the data will need to be filtered for the console anyhow since the console cannot display some of the mouseover and so on stuff anyhow. This would have to be done only for the commands that can be realistically returned to the console anyhow. Right now, even simply commands like /ws who etc cannot be seen properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment