New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp item icons #292

Open
uncovery opened this Issue Apr 28, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@uncovery
Owner

uncovery commented Apr 28, 2017

We currently store item icons by using data in the idemdata array (such as here). We re-download this data every 24 hours and store it on our server.

Instead, we should be using the one-file data here and store the item position in the sprite in the data file for flexible use.

This also goes for the potions and banner patterns etc.

This is both a code improvement (for items where the icon currently exists) as well as a bug fix for items where the icon is currently broken (lingering potions etc)

@uncovery

This comment has been minimized.

Show comment
Hide comment
@uncovery
Owner

uncovery commented May 8, 2018

We will move to use these two datasets once 1.13 is live:

https://github.com/rom1504/minecraft-assets
https://github.com/PrismarineJS/minecraft-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment