fix: Ci build issue regarding release signin config#333
Conversation
WalkthroughThe changes update build configurations and metadata for an Android project. Debug and release builds are now separated in the CI workflow, with improved handling of signing credentials. The Room database disables schema export, dependency versions are updated, and metadata reflects a new application ID, version, and baseline profiles. Changes
Sequence Diagram(s)sequenceDiagram
participant CI as GitHub Actions CI
participant Gradle as Gradle Build System
CI->>Gradle: ./gradlew assembleDebug
Gradle-->>CI: Build debug APK (no signing)
CI->>Gradle: ./gradlew assembleRelease (with signing params)
Gradle-->>CI: Build release APK (signed)
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci_build.yml (1)
121-121: Remove trailing whitespace
Line 121 contains unnecessary spaces. Clean up to satisfy YAML lint.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 121-121: trailing spaces
(trailing-spaces)
app/build.gradle.kts (1)
44-57: Enhance signing config fallback logic
The chained fallback fromlocal.propertiesto system props to defaults is robust, but consider failing the build when critical values (e.g.,storePassword) are empty to avoid silent misconfigurations. You may also referencerootProject.file(...)for clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/ci_build.yml(1 hunks)app/build.gradle.kts(4 hunks)app/release/output-metadata.json(1 hunks)app/src/main/java/com/aritradas/uncrack/data/db/CardDatabase.kt(2 hunks)build.gradle.kts(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/ci_build.yml
[error] 121-121: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
🔇 Additional comments (12)
build.gradle.kts (2)
12-12: Plugin version bump to Kotlin Android 1.9.22
This is a minor version upgrade and aligns with other build components.
20-20: No functional changes in this closing brace; configuration remains intact.app/src/main/java/com/aritradas/uncrack/data/db/CardDatabase.kt (2)
12-13: Disable Room schema export
SettingexportSchema = falseprevents generating the database schema into JSON files. If you intend to maintain versioned schemas for migrations or audits, consider enabling schema export and committing them.
40-40: Closing brace only; no substantive change.app/release/output-metadata.json (5)
7-7: Update applicationId
Changed tocom.aritradas.uncrackto reflect the new package ownership. EnsureAndroidManifest.xmland other references align.
14-15: Bump versionCode and versionName
Updated to16and"3.2.4". Confirm thatversion.propertiesor other version sources remain consistent with these values.
19-19:elementTypeproperty adjustment; no functional impact on the APK metadata.
20-34: Add baseline profile configurations
NewbaselineProfilesentries for API 28–30 and 31+ are included. Verify that the referenced files exist underapp/src/main/baselineProfilesand that they’re packaged appropriately.
36-36: DefineminSdkVersionForDexing
Set to24, matching the module’sminSdk. This aligns dexing with runtime support..github/workflows/ci_build.yml (1)
119-127: Separate debug and release builds with explicit signing
RunningassembleDebugwithout signing andassembleReleasewith injected keystore parameters matches the updated signing config. Good alignment withapp/build.gradle.kts.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 121-121: trailing spaces
(trailing-spaces)
app/build.gradle.kts (2)
89-89: Upgrade Compose compiler extension
Updated to"1.5.8"to align with the latest BOM and plugin versions.
102-102: Apply Compose BOM to Android tests
AddingandroidTestImplementation(composeBom)ensures consistent Compose dependencies in instrumentation tests.
1 participant
Summary by CodeRabbit