Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CSS missing #7

Closed
webjay opened this issue Oct 8, 2013 · 8 comments
Closed

Some CSS missing #7

webjay opened this issue Oct 8, 2013 · 8 comments

Comments

@webjay
Copy link

webjay commented Oct 8, 2013

I tried your project on my project, but found the output missing some CSS parts so the website output isn't correct.
Fork if you would like to test. Sorry I can't point to an error.

@addyosmani
Copy link
Member

No worries at all! This is expected. The current parses being used by unCSS are very limited and ideally we want them to be getting run through PhantomJS. I plan on moving grunt-uncss over to using Helium once it has been ported to Node.

@addyosmani
Copy link
Member

Can you try this out with the latest version of uncss and grunt-uncss and let me know how it goes?

@webjay
Copy link
Author

webjay commented Oct 21, 2013

It works. Thanks.

webjay added a commit to Konfect/konfect.github.com that referenced this issue Oct 21, 2013
@mohammedzamakhan
Copy link

I just wonder how uncss works, since some of the css classes will not be found on page, and will be added through the javascript... !

I have such doubts that don't allow me use such great ideas :(

@Tobino
Copy link

Tobino commented Nov 2, 2013

You can use the ignore option.

options: {
ignore: ['#added_at_runtime', '.created_by_jQuery']
}

uncss/uncss#5

@mohammedzamakhan
Copy link

as @giakki says he will be integrating with PhantonJS, which means that it will solve most of the issues :)

@Tobino it's not easy when you use plugins like Jquery UI or Bootstrap, since you cannot check all the css changes that the plugins make, and it would be hell for us to manually add them...

@addyosmani
Copy link
Member

Yep. For all dynamic JS use-cases, this will be solved once the PhantomJS branch of the associated project by @giakki becomes the default.

On that note, @giakki do you need help with testing out the branch? I'd be happy to see how well it works for the task's use-cases on a few projects if so.

@giakki
Copy link
Member

giakki commented Nov 3, 2013

Sure, it would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants