New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnCSS ignoring complex selectors #74

Closed
addyosmani opened this Issue Jun 30, 2014 · 7 comments

Comments

Projects
None yet
5 participants
@addyosmani
Member

addyosmani commented Jun 30, 2014

Hey @giakki :)

Over in Web Starter Kit our basic layout uses a selector that looks like .app-bar.open ~ main. Unfortunately, this gets skipped by UnCSS, leaving us with a broken menu during our build, meaning we need to add an ignore in place to get this working.

Would it be possible to get some further testing done on why UnCSS is unable to handle such selectors correctly?

@giakki

This comment has been minimized.

Member

giakki commented Jun 30, 2014

Oh no, not that again ;)

I'll look into it. Do you know if this also happens with just .app-bar.open, or .open ~ main?
Thanks!

@addyosmani

This comment has been minimized.

Member

addyosmani commented Jun 30, 2014

We ran into it with .open ~main too if I remember correctly. Hope it doesn't cause too much trouble :)

giakki added a commit that referenced this issue Jul 2, 2014

@giakki

This comment has been minimized.

Member

giakki commented Jul 2, 2014

Added a test.
Seems like updating the dependencies was enough.

Let me know if this was resolved!

@giakki

This comment has been minimized.

Member

giakki commented Jul 2, 2014

Update: I had to unpublish v0.8.2 because of some weird dependency issues. I'll let you know asap!

@seriema

This comment has been minimized.

seriema commented Oct 15, 2014

Maybe related, but my CSS keeps these selectors even though there are no buttons or input elements on my page:

button::-moz-focus-inner,
input::-moz-focus-inner { ... }

@giakki giakki closed this Dec 23, 2014

@ben-eb

This comment has been minimized.

Contributor

ben-eb commented Dec 23, 2014

@giakki It might be worth having a look at the ignore behaviour, such that it could test selectors such as button::-moz-focus-inner against just having a button element in the HTML code, rather than allowing the rule to pass. Imagine this should be a separate ticket though. 😄

@letsila

This comment has been minimized.

letsila commented Jun 15, 2016

Hi !

Combining tow classes selectors like so .first-class.second-class is still skipped. I have tried to ignore them but still doesn't work. The selectors are vanished by uncss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment