This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Standard logger with context support #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyredondo
force-pushed
the
logger-context
branch
3 times, most recently
from
c60ba4f to
e58409e
Compare
drodriguezhdez
approved these changes
Feb 19, 2020
tonyredondo
force-pushed
the
logger-context
branch
5 times, most recently
from
e68b53c to
3bf94d6
Compare
tonyredondo
force-pushed
the
logger-context
branch
from
3bf94d6 to
acfde01
Compare
tonyredondo
force-pushed
the
logger-context
branch
from
acfde01 to
f7aee97
Compare
tonyredondo
force-pushed
the
logger-context
branch
from
f7aee97 to
935aa92
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRadds context support to the standard logger instrumentation, this enables logging inside nested spans, sub tests, and support to parallel tests.The Api is similiar to the Http client request instrumentation:
An Example: