This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Fix support for import autoinstrument and TestMain scopeagent.Run #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyredondo
force-pushed
the
run-method-fix
branch
2 times, most recently
from
c950a9a to
5aa3d43
Compare
drodriguezhdez
approved these changes
Feb 19, 2020
tonyredondo
force-pushed
the
run-method-fix
branch
3 times, most recently
from
267f4db to
2c1cdff
Compare
…l without creating agents twice.
tonyredondo
force-pushed
the
run-method-fix
branch
from
2c1cdff to
df8e52f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix support for
import autoinstrumentandTestMain scopeagent.Runcall in the same package without creating agents and patching twice.The import auto instrumentation patch the
m.Runmethod to callscopeagent.Run, then if we callscopeagent.Runin theTestMainmanually, will call this patched version ofm.Runresulting in callingscopeagent.Runtwice, and patching and creating two agents.By setting a flag we can avoid the recursive call.