This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Support for projects without go.mod #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
tonyredondo
changed the title
tonyredondo
force-pushed
the
no-module-package-name
branch
from
c7b2483 to
2725cba
Compare
tonyredondo
force-pushed
the
no-module-package-name
branch
4 times, most recently
from
c4badc1 to
7c04408
Compare
tonyredondo
force-pushed
the
no-module-package-name
branch
from
e4df17e to
7efbb46
Compare
drodriguezhdez
approved these changes
Mar 5, 2020
Contributor
drodriguezhdez
left a comment
drodriguezhdez
left a comment
There was a problem hiding this comment.
I'd create some tests for instrumentation/testing/utils.go functions.
tonyredondo
force-pushed
the
no-module-package-name
branch
2 times, most recently
from
742220c to
0b37844
Compare
tonyredondo
force-pushed
the
no-module-package-name
branch
from
927a243 to
0301130
Compare
Contributor
|
Approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRimproves support for projects without go modules file (ex: https://github.com/Netflix/chaosmonkey) by exportingSourceRootfrom the agent metadata:Before:
After:
