This repository was archived by the owner on Aug 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Recorder buffer refactor #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Other test with massive spans and events: |
3d282dc to
ba72276
Compare
Contributor
|
You've changed the buffer from RawSpans to ScopeSpans, any particular reason that could be applied to other agents for that change? |
drodriguezhdez
approved these changes
Mar 5, 2020
Contributor
Author
|
So now the recorder instead of sending 1000 spans with all events of these spans, will be sending 1000 spans and 1000 events per payload. This should improve the ingest performance. |
fermayo
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171
This
PRsplit the current recorder buffer to spans and events, allowing to send a max number of each type in every payload.Example: