This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Forbid empty sourceroot and go.mod path finder #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRadds an additional fallback when the source root can't be detected (to improve the detection of a valid source root). This fallback is based on the path of thego.modfile, using the current folder as the starting point and going up from parent to parent folder.According https://blog.golang.org/using-go-modules the
go.modfile should be at the root of the project (in case the project is using go modules).With this
PRthe source root detector has the following priorities:SCOPE_SOURCE_ROOTenvironment variable..gitfolder root pathgo.modpath/