This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Improvements from Buildkit instrumentation #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt into test-code-api
drodriguezhdez
approved these changes
Apr 6, 2020
Contributor
|
These changes were tested against |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRcontains cumulative improvements made based in the Buildkit instrumentation.Added:
scopeagent.SetTestCodeFromCaller,scopeagent.SetTestCodeFromCallerSkipandscopeagent.SetTestCodeFromFuncto manually set the function containing the source code of a test. With this we calculate the suite name and the test source code boundaries. This is used when a test code it's wrapped with a library.Changed:
Fixed:
t.Parallel()removing the previous behavior that contains the time before the pause of the parallel.t.Logmonkey patching methods, due a problem in Golangreflect.makefuncavoiding the segmentation fault when calling the log methods from several go routines at the same time.