Skip to content
This repository was archived by the owner on Aug 17, 2020. It is now read-only.

Conversation

@tonyredondo
Copy link
Contributor

This PR changes the testing logger instrumentation with a simpler implementation with the following important changes.

  • No locking/mutex.
  • No storing patch uintptr in a map (this could throw segmentation fault with an invalid ptr when the GC is executing).
  • No Patch and Unpatch in every call (there was a corner case with a race condition that could cause some log events not being catched at all). Now we only patch/unpatch at the beginning and the end.
  • Remove dynamic method creation with reflection.
  • Fixes the methodBody variadic call.

This implementation should avoid any segmentation fault related with logging.

@tonyredondo tonyredondo self-assigned this Jun 1, 2020
@tonyredondo tonyredondo merged commit 4c4d205 into master Jun 2, 2020
@tonyredondo tonyredondo deleted the seg-fault-fix branch June 2, 2020 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants