This repository was archived by the owner on Aug 17, 2020. It is now read-only.
testing logger instrumentation changes #241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRchanges the testing logger instrumentation with a simpler implementation with the following important changes.uintptrin a map (this could throw segmentation fault with an invalid ptr when the GC is executing).PatchandUnpatchin every call (there was a corner case with a race condition that could cause some log events not being catched at all). Now we only patch/unpatch at the beginning and the end.methodBodyvariadic call.This implementation should avoid any segmentation fault related with logging.