From 30daa01a322d07d6cf228a5f47fbb93623ef1557 Mon Sep 17 00:00:00 2001 From: Daniel Redondo Date: Tue, 2 Jun 2020 13:08:11 +0200 Subject: [PATCH 1/2] remove the SetRand to uuid --- tracer/util.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/tracer/util.go b/tracer/util.go index 530bebfe..08977d61 100644 --- a/tracer/util.go +++ b/tracer/util.go @@ -28,7 +28,6 @@ func getRandomId() uint64 { func getRandomUUID() uuid.UUID { mu.Lock() defer mu.Unlock() - ensureRandom() return uuid.New() } @@ -37,7 +36,6 @@ func ensureRandom() { random = rand.New(&safeSource{ source: rand.NewSource(getSeed()), }) - uuid.SetRand(random) } } From 9c9b4d6bad90c58a1c268badf0ae008023aca40b Mon Sep 17 00:00:00 2001 From: Daniel Redondo Date: Tue, 2 Jun 2020 13:19:25 +0200 Subject: [PATCH 2/2] removes mutex for uuid.New() --- tracer/tracer.go | 2 +- tracer/util.go | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/tracer/tracer.go b/tracer/tracer.go index 9abb6619..40ea8a2d 100644 --- a/tracer/tracer.go +++ b/tracer/tracer.go @@ -200,7 +200,7 @@ ReferencesLoop: if sp.raw.Context.TraceID.String() == emptyUUID { // No parent Span found; allocate new trace and span ids and determine // the Sampled status. - sp.raw.Context.TraceID = getRandomUUID() + sp.raw.Context.TraceID = uuid.New() sp.raw.Context.SpanID = getRandomId() sp.raw.Context.Sampled = t.options.ShouldSample(sp.raw.Context.TraceID) } diff --git a/tracer/util.go b/tracer/util.go index 08977d61..8544469c 100644 --- a/tracer/util.go +++ b/tracer/util.go @@ -25,12 +25,6 @@ func getRandomId() uint64 { return random.Uint64() } -func getRandomUUID() uuid.UUID { - mu.Lock() - defer mu.Unlock() - return uuid.New() -} - func ensureRandom() { if random == nil { random = rand.New(&safeSource{