This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Fix test span counter #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguezhdez
approved these changes
Jun 5, 2020
| for _, span := range spans { | ||
| if isTestSpan(span) { | ||
| testSpans++ | ||
| if tags, ok := span["tags"].(opentracing.Tags); ok { |
Contributor
There was a problem hiding this comment.
Which cases it gave a wrong test span count?
Contributor
Author
There was a problem hiding this comment.
Here: https://github.com/undefinedlabs/scope-go-agent/blob/fix-test-counter/agent/recorder.go#L181-L189
The problem with that counter, is that is being used here: https://github.com/undefinedlabs/scope-go-agent/blob/fix-test-counter/agent/report.go#L12
So if the that value is always zero, always return "success" while we have some KO in the backend...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test span counter used by the report message at the end of the tests.