Skip to content

Redis dataset take2#22

Merged
undera merged 9 commits into
undera:masterfrom
pmouawad:REDIS_DATASET_TAKE2
Dec 29, 2013
Merged

Redis dataset take2#22
undera merged 9 commits into
undera:masterfrom
pmouawad:REDIS_DATASET_TAKE2

Conversation

@pmouawad
Copy link
Copy Markdown
Contributor

Hello Andrey,
Following your notes on REDIS_DATASET first pull request, find below a new Pull Request following your dev guidelines I hope.

Regards
Philippe M.
@philmdot

@pmouawad pmouawad mentioned this pull request Dec 28, 2013
@undera
Copy link
Copy Markdown
Owner

undera commented Dec 28, 2013

Why the dependency for JMeter is changed from 2.8 to 2.10? I think it is good to support old versions if possible.

@pmouawad
Copy link
Copy Markdown
Contributor Author

Because I use method:
BeanInfoSupport#property(String, Class>) which appeared in jmeter 2.10
https://issues.apache.org/bugzilla/show_bug.cgi?id=55421

Regards
Philippe M.

@undera
Copy link
Copy Markdown
Owner

undera commented Dec 29, 2013

Ok, then this requirement must be included in wiki page, because it conflicts with common JP@GC Jmeter version requirement, as mentioned on the home page.

undera pushed a commit that referenced this pull request Dec 29, 2013
@undera undera merged commit dc663c2 into undera:master Dec 29, 2013
@pmouawad
Copy link
Copy Markdown
Contributor Author

Thanks for merging.
Where do I add it ? In the Redis Data Set wiki page ? or somewhere else ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants