Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint to version 5.6.1 #44

merged 1 commit into from Sep 29, 2018


Copy link

commented Sep 29, 2018

We've upgraded a dependency and all tests pass. \o/

name version specification new version
eslint 5.6.0 5.6.1

You should probably take a good look at this before merging this pull request, of course.

What changed?

✳️ eslint ( → 5.6.1) · Repo · Changelog

Release Notes


  • 9b26bdb Fix: avoid exponential require-atomic-updates traversal (fixes #10893) (#10894) (Teddy Katz)
  • 9432b10 Fix: make separateRequires work in consecutive mode (fixes #10784) (#10886) (Pig Fang)
  • e51868d Upgrade: debug@4 (fixes #10854) (#10887) (薛定谔的猫)
  • d3f3994 Docs: add information about reporting security issues (#10889) (Teddy Katz)
  • cc458f4 Build: fix failing tests on master (#10890) (Teddy Katz)
  • a6ebfd3 Docs: clarify defaultAssignment option, fix no-unneeded-ternary examples (#10874) (CoffeeTableEspresso)
  • 9d52541 Fix: Remove duplicate error message on crash (fixes #8964) (#10865) (Nicholas C. Zakas)
  • 4eb9a49 Docs: Update (#10862) (The Jared Wilcurt)
  • 9159e9b Docs: Update (#10867) (Szymon Przybylski)
  • 14f4e46 Docs: Use Linter instead of linter in Nodejs API page (#10864) (Nicholas C. Zakas)
  • b3e3cb1 Chore: Update debug log name to match filename (#10863) (Nicholas C. Zakas)


  • c5b688e Update: Added generators option to func-names (fixes #9511) (#10697) (Oscar Barrett)
  • 7da36d5 Fix: respect generator function expressions in no-constant-condition (#10827) (Julian Rosse)
  • 0a65844 Chore: quote enable avoidEscape option in eslint-config-eslint (#10626) (薛定谔的猫)
  • 32f41bd Chore: Add configuration wrapper markdown for the bug report template (#10669) (Iulian Onofrei)


  • 6e110e6 Fix: camelcase duplicate warning bug (fixes #10801) (#10802) (Julian Rosse)
  • 5103ee7 Docs: Add Brackets integration (#10813) (Jan Pilzer)
  • b61d2cd Update: max-params to only highlight function header (#10815) (Ian Obermiller)
  • 2b2f11d Upgrade: babel-code-frame to version 7 (#10808) (Rouven Weßling)
  • 2824d43 Docs: fix comment placement in a code example (#10799) (Vse Mozhet Byt)
  • 10690b7 Upgrade: devdeps and deps to latest (#10622) (薛定谔的猫)
  • 80c8598 Docs: gitignore syntax updates (fixes #8139) (#10776) (Gustavo Santana)
  • cb946af Chore: use meta.messages in some rules (1/4) (#10764) (薛定谔的猫)


  • a70909f Docs: Add links (#10771) (Gustavo Santana)
  • 034690f Fix: no-invalid-meta crashes for non Object values (fixes #10750) (#10753) (Sandeep Kumar Ranka)
  • 11a462d Docs: Broken URLs (fixes #10732) (#10770) (Gustavo Santana)
  • 985567d Chore: rm unused dep string.prototype.matchall (#10756) (薛定谔的猫)
  • f3d8454 Update: Improve no-extra-parens error message (#10748) (Timo Tijhof)
  • 562a03f Fix: consistent-docs-url crashes if is empty (fixes #10722) (#10749) (Sandeep Kumar Ranka)
  • 6492233 Chore: enable no-prototype-builtins in codebase (fixes #10660) (#10664) (薛定谔的猫)
  • 137140f Chore: use eslintrc overrides (#10677) (薛定谔的猫)


  • dd6cb19 Docs: Updated no-return-await Rule Documentation (fixes #9695) (#10699) (Marla Foreman)
  • 6009239 Chore: rename utils for consistency (#10727) (薛定谔的猫)
  • 6eb972c New: require-unicode-regexp rule (fixes #9961) (#10698) (Toru Nagashima)
  • 5c5d64d Fix: ignored-paths for Windows path (fixes #10687) (#10691) (Toru Nagashima)
  • 5f6a765 Build: ensure URL fragments remain in documentation links (fixes #10717) (#10720) (Teddy Katz)
  • 863aa78 Docs: add another example for when not to use no-await-in-loop (#10714) (Valeri Karpov)
  • 6e78b7d Docs: remove links to terminated domain (#10706) (Piotr Kuczynski)
  • d56c39d Fix: ESLint cache no longer stops autofix (fixes #10679) (#10694) (Kevin Partington)
  • 2cc3240 New: add no-misleading-character-class (fixes #10049) (#10511) (Toru Nagashima)
  • 877f4b8 Fix: The "../.." folder is always ignored (fixes #10675) (#10682) (Sridhar)
  • 5984820 Chore: Move lib/file-finder.js to lib/util/ (refs #10559) (#10695) (Kevin Partington)
  • e37a593 Update: Fix incorrect default value for position (#10670) (Iulian Onofrei)
  • 8084bfc Docs: change when not to use object spread (#10621) (Benny Powers)
  • 7f496e2 Chore: Update require path for ast-utils (#10693) (Kevin Partington)
  • 648a33a Chore: reorganize code structure of utilities (refs #10599) (#10680) (薛定谔的猫)
  • f026fe1 Update: Fix 'function' in padding-line-between-statements (fixes #10487) (#10676) (Kevin Partington)
  • c2bb8bb Docs: Remove superfluous object option sample code (#10652) (Iulian Onofrei)
  • d34a13b Docs: add subheader in configuring/configuring-rules (#10686) (薛定谔的猫)
  • d8aea28 Chore: rm unnecessary plugin in eslint-config-eslint (#10685) (薛定谔的猫)
  • 9e76be7 Update: indent comments w/ nearby code if no blank lines (fixes #9733) (#10640) (Kevin Partington)
  • 9e93d46 New: add no-async-promise-executor rule (fixes #10217) (#10661) (Teddy Katz)
  • 5a2538c New: require-atomic-updates rule (fixes #10405) (#10655) (Teddy Katz)
  • 8b83d2b Fix: always resolve default ignore patterns from CWD (fixes #9227) (#10638) (Teddy Katz)
  • acb6658 Fix: ESLint crash with prefer-object-spread (fixes #10646) (#10649) (薛定谔的猫)
  • 99fb7d3 Docs: fix misleading no-prototype-builtins description (#10666) (薛定谔的猫)
  • 005b849 Docs: fix outdated description of baseConfig option (#10657) (Teddy Katz)
  • 15a77c4 Docs: fix broken links (fixes eslint/eslint-jp#6) (#10658) (Toru Nagashima)
  • 87cd344 Docs: Make marking a default option consistent with other rules (#10650) (Iulian Onofrei)
  • 0cb5e3e Chore: Replace some function application with spread operators (#10645) (Kevin Partington)
  • b6daf0e Docs: Remove superfluous section from no-unsafe-negation (#10648) (Iulian Onofrei)
  • e1a3cac Chore: rm deprecated experimentalObjectRestSpread option in tests (#10647) (薛定谔的猫)


  • 81283d0 Update: Cache files that failed linting (fixes #9948) (#10571) (Kevin Partington)
  • 13cc63e Upgrade: ignore@4.0.2 (#10619) (Rouven Weßling)
  • ac77a80 Chore: Fixing a call to Object.assign.apply in Linter (#10629) (Kevin Partington)
  • 761f802 Upgrade: eslint-plugin-node to 7.0.1 (#10612) (Toru Nagashima)
  • c517b2a Build: fix npm run perf failing(fixes #10577) (#10607) (薛定谔的猫)
  • e596939 Chore: fix redundant equality check (#10617) (Toru Nagashima)
  • 9f93d5f Docs: Updated Working with Custom Formatters (fixes #9950) (#10592) (Marla Foreman)
  • 9aaf195 Chore: Extract lint result cache logic (refs #9948) (#10562) (Kevin Partington)
  • 80b296e Build: package.json update for eslint-config-eslint release (ESLint Jenkins)
  • e4e7ff2 Chore: fix error message in eslint-config-eslint (#10588) (薛定谔的猫)
  • 1e88170 Chore: Move lib/logging and lib/timing to lib/util/ (refs #10559) (#10579) (Kevin Partington)
  • 64dfa21 Build: Fix prerelease logic in blog post generation (fixes #10578) (#10581) (Kevin Partington)
  • 0faf633 Chore: Simplify helper method in Linter tests (#10580) (Kevin Partington)


  • 7328f99 Build: package.json update for eslint-config-eslint release (ESLint Jenkins)
  • b161f6b Build: Include prerelease install info in release blog post (#10463) (Kevin Partington)
  • b2df738 Fix: prefer-object-spread duplicated comma (fixes #10512, fixes #10532) (#10524) (Toru Nagashima)
  • d8c3a25 Fix: wrap-regex doesn't work in some expression(fixes #10573) (#10576) (薛定谔的猫)
  • 114f42e Docs: Clarify option defaults in max-lines-per-function docs (#10569) (Chris Harwood)
  • 63f36f7 Fix: sort-keys in an object that contains spread (fixes #10261) (#10495) (katerberg)
  • 601a5c4 Fix: Prefer-const rule crashing on array destructuring (fixes #10520) (#10527) (Michael Mason)
  • 143890a Update: Adjust grammar of error/warnings fixable (#10546) (Matt Mischuk)
  • 8ee39c5 Chore: small refactor config-validator (#10565) (薛定谔的猫)
  • 100f1be Docs: add note about release issues to readme (#10572) (Teddy Katz)
  • 02efeac Fix: do not fail on nested unknown operators (#10561) (Rubén Norte)
  • 92b19ca Chore: use eslintrc overrides(dogfooding) (#10566) (薛定谔的猫)
  • 076a6b6 Docs: add actionable fix to no-irregular-whitespace (#10558) (Matteo Collina)
  • de663ec Docs: Only successfully linted files are cached (fixes #9802) (#10557) (Kevin Partington)
  • f0e22fc Upgrade: globals@11.7.0 (#10497) (薛定谔的猫)
  • 8a2ff2c Docs: adding a section about disable rules for some files (#10536) (Wellington Soares)
  • f22a3f8 Docs: fix a word in no-implied-eval (#10539) (Dan Homola)
  • 20d8bbd Docs: add missing paragraph about "custom parsers" (#10547) (Pig Fang)
  • b7addf6 Update: deprecate no-catch-shadow (fixes #10466) (#10526) (Toru Nagashima)
  • e862dc3 Fix: Remove autofixer for no-debugger (fixes #10242) (#10509) (Teddy Katz)


  • 196c102 Fix: valid-jsdoc should allow optional returns for async (fixes #10386) (#10480) (Mark Banner)
  • 4c823bd Docs: Fix max-lines-per-function correct code's max value (#10513) (Rhys Bower)


Release blogpost

Migration guide

  • 0feedfd New: Added max-lines-per-function rule (fixes #9842) (#10188) (peteward44)
  • daefbdb Upgrade: eslint-scope and espree to 4.0.0 (refs #10458) (#10500) (Brandon Mills)
  • 077358b Docs: no-process-exit: recommend process.exitCode (#10478) (Andres Kalle)
  • f93d6ff Fix: do not fail on unknown operators from custom parsers (fixes #10475) (#10476) (Rubén Norte)
  • 05343fd Fix: add parens for yield statement (fixes #10432) (#10468) (Pig Fang)
  • d477c5e Fix: check destructuring for "no-shadow-restricted-names" (fixes #10467) (#10470) (Pig Fang)
  • 7a7580b Update: Add considerPropertyDescriptor option to func-name-matching (#9078) (Dieter Luypaert)
  • e0a0418 Fix: crash on optional catch binding (#10429) (Toru Nagashima)
  • de4dba9 Docs: styling team members (#10460) (薛定谔的猫)
  • 5e453a3 Docs: display team members in tables. (#10433) (薛定谔的猫)
  • b1895eb Docs: Restore intentional spelling mistake (#10459) (Wilfred Hughes)


  • 3ff5d11 Fix: no-invalid-regexp not understand variable for flags (fixes #10112) (#10113) (薛定谔的猫)
  • abc765c Fix: object-curly-newline minProperties w/default export (fixes #10101) (#10103) (Kevin Partington)
  • 6f9e155 Docs: Update ambiguous example for guard-for-in (#10114) (CJ R)
  • 0360cc2 Chore: Adding debug logs on successful plugin loads (#10100) (Kevin Partington)
  • a717c5d Chore: Adding log at beginning of unit tests in Makefile.js (#10102) (Kevin Partington)

Not all release notes shown. View the full release notes


See the full diff on Github. The new version differs by 13 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Sep 29, 2018

This comment has been minimized.

Copy link

commented Sep 29, 2018

@depfu merge


This comment has been minimized.

Copy link

commented Sep 29, 2018

Coverage Status

Coverage remained the same at 96.234% when pulling f427ef1 on depfu/update/npm/eslint-5.6.1 into 9d70fae on master.

@papandreou papandreou merged commit beb104e into master Sep 29, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage remained the same at 96.234%
@depfu depfu bot deleted the depfu/update/npm/eslint-5.6.1 branch Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.