Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v10 shift #219

Merged
merged 10 commits into from Oct 6, 2015

Conversation

Projects
None yet
2 participants
@sunesimonsen
Copy link
Member

commented Oct 6, 2015

Provides an improved expect.shift method.

papandreou added some commits Oct 4, 2015

Reworked shift to take advantage of the <assertion> type.
Hacked in detection of the arguments which are assertions so the standard error message isn't broken.
createStandardErrorMessage: Don't break when the assertion pointed to…
… by the argument declared <assertion> does not exist.
Allow <assertion?>.
Also, make expect.shift return the subject when there's no assertion to delegate to so that the shifted subject will be provided as the promise fulfillment value when the return value of expect.shift is returned from the assertion handler.
when decoded as, when passed as parameter(s) to, when called with: Pr…
…ovide the result as the fulfillment value if no assertion is provided.

sunesimonsen added a commit that referenced this pull request Oct 6, 2015

@sunesimonsen sunesimonsen merged commit db93390 into spike/v10-duck-typing Oct 6, 2015

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 96.11%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sunesimonsen sunesimonsen deleted the feature/v10-shift branch Oct 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.