Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to have (items|values|keys) satisfying: Only allow one <any> as the value, not <any+> #348

Merged
merged 1 commit into from Nov 18, 2016

Conversation

papandreou
Copy link
Member

No description provided.

@papandreou papandreou changed the title to have (items|values|keys) satisfying: Only allow one <any> as the value, not <any+>. to have (items|values|keys) satisfying: Only allow one <any> as the value, not <any+> Nov 17, 2016
'<array-like> to have items [exhaustively] satisfying <assertion>',
'<array-like> to be an array whose items [exhaustively] satisfy <any+>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a good way :). Only suites that accidentally pass additional arguments (which are currently silently ignored) will break.

@sunesimonsen
Copy link
Member

It looks like we used apply in this case, would that have worked with
varargs assertions like to have keys?
On Fri, 18 Nov 2016 at 07.06, Andreas Lind notifications@github.com wrote:

@papandreou commented on this pull request.

In lib/assertions.js #348
:

     '<array-like> to have items [exhaustively] satisfying <assertion>',
  •    '<array-like> to be an array whose items [exhaustively] satisfy <any+>',
    

In a good way :). Only suites that accidentally pass additional arguments
(which are currently silently ignored) will break.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#348, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFisqXFd0viVyCEYMMZcCWoPAGMnUdzks5q_UBIgaJpZM4K17Oo
.

@papandreou
Copy link
Member Author

No, to satisfy never takes varargs, except in the <assertion> case.

@sunesimonsen
Copy link
Member

Okay then this is just a bugfix 👍

@papandreou papandreou merged commit 92cc275 into master Nov 18, 2016
@papandreou papandreou deleted the feature/disallowAnyPlus branch November 18, 2016 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants