Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix error on promise .and() #428
Looks great, just a few minor nits.
Yeah, I'm fairly sure that a similar treatment is needed in a bunch of other places. Could be interesting to try to see if a similar error can be provoked from other angles.
In any case, this is a very useful fix on its own, so there's no reason to expand the scope.
@papandreou I’ve pushed changes that should address all of your review comments. I took the opportunity to do what we discussed around entirely replacing isPromisePending and did manage to reproduce the issue in the other place - have included that test too :)