New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated support for this.subject etc. in assertion handlers #567

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@papandreou
Copy link
Member

papandreou commented Jan 5, 2019

As discussed on gitter.

Has been deprecated and undocumented since around Unexpected 3, so it's very unlikely to be in use :)

@papandreou papandreou self-assigned this Jan 5, 2019

@papandreou papandreou requested review from alexjeffburke and sunesimonsen Jan 5, 2019

@sunesimonsen
Copy link
Member

sunesimonsen left a comment

👍

@alexjeffburke
Copy link
Member

alexjeffburke left a comment

Let's do it!

@papandreou papandreou merged commit 55b7bb6 into v11 Jan 5, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.004%
Details
deploy/netlify Deploy preview ready!
Details

@papandreou papandreou deleted the chore/unsupportThisInAssertions branch Jan 5, 2019

@sunesimonsen sunesimonsen referenced this pull request Jan 5, 2019

Merged

V11 (Major) #509

25 of 25 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment