Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-plugin-node to version 10.0.0 #663

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@depfu
Copy link
Contributor

commented Sep 6, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ eslint-plugin-node (^9.0.1 → ^10.0.0) · Repo

Release Notes

10.0.0

This release supports BigInt and Dynamic Imports if you are using ESLint 6.2.0 or later.

💥 Breaking Changes

  • 9ea67c9 updated node/no-unsupported-features/es-syntax rule to recognize BigInt literals and import().
  • b91b48d updated node/no-unsupported-features/es-builtins rule to recognize BigInt, BigInt64Array, BigUint64Array, and Promise.allSettled.
  • b57a4f9 updated node/file-extension-in-import, node/no-extraneous-import, node/no-missing-import, and node/no-unpublished-import rules to recognize import().
  • 4b9c4d7 updated node/no-deprecated-api rule to recognize module.createRequireFromPath.
  • 9c574ba updated plugin:node/recommended and the other configs.
    • It added node/no-exports-assign rule.
    • It changed exports global variable writable.
    • It enabled node/*-import rules in CommonJS mode as well.

New rules

  • a0f0ee1 added node/no-exports-assign rule that disallows exports = {}.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 18 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Sep 6, 2019

@papandreou papandreou merged commit b049d34 into master Sep 6, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.999%
Details

@depfu depfu bot deleted the depfu/update/npm/eslint-plugin-node-10.0.0 branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.