Absorb the unexpected-set plugin #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think varargs is more okay now that you can do array splatting, so I don't think we should remove it. |
papandreou
force-pushed
the
feature/absorbUnexpectedSet
branch
from
778dd56 to
391a3e0
Compare
papandreou
force-pushed
the
feature/absorbUnexpectedSet
branch
from
5053b30 to
dfefba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLUUUURRRP! 🤤
Excluding the
<array-like> with set semantics <assertion?>assertion which I think is a bit too opinionated/obscure for core.TODO:
<Set> [not] to contain <any>to take varargs like<array-like> [not] to contain <any+>and<string> [not] to contain <string+>. (Or remove the ability from the other ones, it might be a bit obscure)Set#hasuses the SameValueZero algorithm, but we should probably plug in unexpected's ownequalin some cases, such asto contain. Right now this fails:expect(new Set([new Date('2020-01-01T12:34:56.789Z')]), 'to contain', new Date('2020-01-01T12:34:56.789Z'));