Added 2 simple commands for skip forward and backward #19
Conversation
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
Thanks the enhancement! Playback control really is a hit-or-miss with some apps.
I've quickly verified it and it looks good to me.
Please fix the pylint issues, then I'll merge it.
|
It should be okay now ! Keep up the good work ! |
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
Sorry to bother you again, linting check is still failing.
You can easily check & format it locally: https://github.com/unfoldedcircle/integration-appletv/blob/main/docs/code_guidelines.md#verify
|
Hi Markus,
No problem, code formating was okay (with black) but I forgot to apply "sort imports" tasks.
Done now
Cheers,
Damien
De : Markus Zehnder ***@***.***>
Envoyé : lundi 10 juin 2024 18:11
À : unfoldedcircle/integration-appletv ***@***.***>
Cc : albaintor ***@***.***>; Author ***@***.***>
Objet : Re: [unfoldedcircle/integration-appletv] Added 2 simple commands for skip forward and backward (PR #19)
@zehnm requested changes on this pull request.
Sorry to bother you again, linting check is still failing.
You can easily check & format it locally: https://github.com/unfoldedcircle/integration-appletv/blob/main/docs/code_guidelines.md#verify
-
Reply to this email directly, view it on GitHub<#19 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4IHILEC3LCKSA4W6BHVLWLZGXF2XAVCNFSM6AAAAABICCZ6S2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBYGIZDGNRVGI>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
Sorry either I was blind but I didn't any warning after running checks... should be fixed now...hopefully |
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
One last python -m isort intg-appletv/. and it should be good :-)
|
OMG, I am so bad... sorry I want to go fast and this is worse |
2 participants
Hi,
I added those 2 simple commands that were already defined in the integration library but unmapped. It will address some apps having issues with fast forward / rewind commands (disney+)