Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Selection text and Green check displayed in tN for a verse that has two checks. #6389

Open
elsylambert opened this issue Aug 19, 2019 · 6 comments

Comments

@elsylambert
Copy link

commented Aug 19, 2019

2.0.0 (cb75770).
Here is the project:
en_new_1ti_book.zip

Steps to replicate:

  1. In tN. make selection for a verse that has two checks. For e.g. In this project, 1ti 6:13 there are two checks in tN under category "Assumed Knowledge..."
  2. Make selection for both the verses and save.
  3. Selections seems fine on the left side menu bar.
  4. Re-open tN and see the Same verse selections. Note that the left side menu bar has display issue as in the snapshot below:
    image

Another Case when there are only one selection out of the two verses:
In Phm project, Phm 1:1 there are two checks in tN, seems that the one with the green check is not completed rather one with no checkmark has selections.
This is under the category "Exclusive and Inclusive we". Another Category has the same issue"How to translate Names" in Phm 1:2".
image

@PhotoNomad0

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2019

@elsylambert - In the first case, I only see this error when I exit tN and then open wA and then go back to tN. Just relaunching tN does not cause this. And going from tN to tW to tN does not cause it. It also looks like it is a transient error since if I open a different project and return, the problem clears.

@PhotoNomad0

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2019

@elsylambert - In the second case, if I go into WA and back to tN, I see both items have checkmarks even though only one has selections.
Screen Shot 2019-08-20 at 9 35 12 AM

@mannycolon mannycolon self-assigned this Aug 22, 2019
@cckozie

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

@mannycolon
I have now seen the same or similar behavior in tW.
Screenshot after completing both checks for the same verse:
image

Screenshot after loading the project in wA and then returning to tW:
image

@PhotoNomad0

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

@mannycolon - I found the cause for the leakage of selections. My fault. To fix need to change in GroupsDataActions:

export const findGroupDataItem = (contextId, groupData) => {
  let index = -1;
  for (let i = 0, l = groupData.length; i < l; i++) {
    const grpContextId = groupData[i].contextId;
    if ((grpContextId.quote === contextId.quote) &&
        isEqual(grpContextId.reference, contextId.reference) &&
        (grpContextId.occurrence === contextId.occurrence)) {
      index = i;
      break;
    }
  }
  return index;
};

I have a PR that will be ready soon and can fix it there if you want.

@PhotoNomad0

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2019

Hmm...looks like it is not the only problem.

@elsylambert

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

Tested on 2.0.0 (ca6c273).
Made selection for a verse 2Timothy 1:5, but the green check mark was not displayed.
Later found that 2Timothy 1:5 had content error in a different category.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.