Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add dry run option #102

Closed
telmich opened this Issue Oct 2, 2012 · 6 comments

Comments

Projects
None yet
2 participants
Contributor

telmich commented Oct 2, 2012

Similar to patch, use -n, --dry-run.

Contributor

telmich commented Oct 2, 2012

Implementation: Execute everything, but skip the code execution phase. Maybe a simple

if not dry_run:
self.code.run_code_remote() ... (and local)

@ghost ghost assigned telmich Dec 19, 2012

Contributor

telmich commented Dec 19, 2012

Began code change in resolver branch in config_install.py

Contributor

dheule commented Feb 8, 2014

I think this issue is implemented via

-n, --dry-run Do not execute code

is this correct ? can we close this issue ?

Contributor

telmich commented Feb 9, 2014

I think it's only the command line option that has been implemented - at
least I remember there are no unit tests for it (=it does not exist ;-)
and I am pretty sure I have never tested it. :-)

Just my 2 rappen from Lenzerheide,

Nico

dheule [Sat, Feb 08, 2014 at 11:45:20AM -0800]:

I think this issue is implemented via

-n, --dry-run Do not execute code

is this correct ? can we close this issue ?


Reply to this email directly or view it on GitHub:
telmich#102 (comment)

PGP key: 7ED9 F7D3 6B10 81D7 0EC5 5C09 D7DC C8E4 3187 7DF0

Contributor

dheule commented Feb 9, 2014

I have tested it (manual), seems to work.

Ok, i will try my best for unittests next week ...

Daniel

2014-02-09 18:57 GMT+01:00 Nico Schottelius notifications@github.com:

I think it's only the command line option that has been implemented - at
least I remember there are no unit tests for it (=it does not exist ;-)
and I am pretty sure I have never tested it. :-)

Just my 2 rappen from Lenzerheide,

Nico

dheule [Sat, Feb 08, 2014 at 11:45:20AM -0800]:

I think this issue is implemented via

-n, --dry-run Do not execute code

is this correct ? can we close this issue ?


Reply to this email directly or view it on GitHub:
telmich#102 (comment)

PGP key: 7ED9 F7D3 6B10 81D7 0EC5 5C09 D7DC C8E4 3187 7DF0


Reply to this email directly or view it on GitHubhttps://github.com/telmich/cdist/issues/102#issuecomment-34580606
.

Contributor

dheule commented Feb 12, 2014

I think now it's ok to close this bug ...

@dheule dheule closed this Feb 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment