New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #26

Merged
merged 3 commits into from Nov 5, 2017

Conversation

Projects
None yet
1 participant
@unhappychoice
Owner

unhappychoice commented Nov 5, 2017

  • close #21
  • Fix build log is not update in real time
  • Fix build step rows is not rendered correctly
@codecov

This comment has been minimized.

codecov bot commented Nov 5, 2017

Codecov Report

Merging #26 into master will decrease coverage by 0.05%.
The diff coverage is 4.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #26      +/-   ##
==========================================
- Coverage      4.45%   4.4%   -0.06%     
  Complexity       13     13              
==========================================
  Files            46     46              
  Lines           583    590       +7     
  Branches         67     69       +2     
==========================================
  Hits             26     26              
- Misses          555    562       +7     
  Partials          2      2
Impacted Files Coverage Δ Complexity Δ
.../norimaki/presentation/presenter/BuildPresenter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...presentation/presenter/core/PresenterNeedsToken.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...rimaki/infrastructure/pusher/response/ActionLog.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...imaki/presentation/presenter/BuildStepPresenter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...appychoice/norimaki/di/module/ApplicationModule.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/unhappychoice/norimaki/domain/model/BuildStep.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...norimaki/di/module/screen/BuildStepScreenModule.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ce/norimaki/presentation/screen/BuildStepScreen.kt 75% <50%> (ø) 3 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8738f5...bee5c87. Read the comment docs.

@unhappychoice unhappychoice force-pushed the fix-bugs branch from c050cec to 6303aa7 Nov 5, 2017

@unhappychoice unhappychoice force-pushed the fix-bugs branch from 2e69156 to bee5c87 Nov 5, 2017

@unhappychoice unhappychoice merged commit f1faaae into master Nov 5, 2017

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details

@unhappychoice unhappychoice deleted the fix-bugs branch Nov 5, 2017

@Tunous Tunous referenced this pull request Nov 5, 2017

Merged

Rx refactor v2 #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment