New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodein #27

Merged
merged 2 commits into from Nov 18, 2017

Conversation

Projects
None yet
1 participant
@unhappychoice
Owner

unhappychoice commented Nov 18, 2017

No description provided.

@codecov

This comment has been minimized.

codecov bot commented Nov 18, 2017

Codecov Report

Merging #27 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #27      +/-   ##
===========================================
+ Coverage       4.4%   4.45%   +0.04%     
  Complexity       13      13              
===========================================
  Files            46      45       -1     
  Lines           590     584       -6     
  Branches         69      77       +8     
===========================================
  Hits             26      26              
+ Misses          562     556       -6     
  Partials          2       2
Impacted Files Coverage Δ Complexity Δ
...ce/norimaki/presentation/screen/BuildListScreen.kt 100% <ø> (+25%) 3 <0> (ø) ⬇️
...ice/norimaki/presentation/screen/APITokenScreen.kt 100% <ø> (+25%) 3 <0> (ø) ⬇️
...choice/norimaki/presentation/screen/BuildScreen.kt 50% <ø> (-25%) 3 <0> (ø)
.../com/unhappychoice/norimaki/NorimakiApplication.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...choice/norimaki/presentation/core/ScreenChanger.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../norimaki/presentation/adapter/BuildStepAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../norimaki/presentation/presenter/BuildPresenter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...choice/norimaki/di/screen/BuildStepScreenModule.kt 0% <0%> (ø) 0 <0> (?)
...imaki/presentation/presenter/BuildStepPresenter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...rimaki/presentation/presenter/APITokenPresenter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2031f...ac5dc35. Read the comment docs.

@unhappychoice unhappychoice merged commit b66a962 into master Nov 18, 2017

4 of 5 checks passed

codecov/patch 0% of diff hit (target 4.4%)
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codecov/project 4.45% (+0.04%) compared to 8e2031f
Details

@unhappychoice unhappychoice deleted the kodein branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment