chore: update deps #121
chore: update deps #121
Conversation
FliPPeDround
force-pushed
the
chore/update-deps
branch
from
0a6773e to
f3db567
Compare
WalkthroughDependency and devDependency version bumps across multiple template package.json files under packages/core/template, affecting UI templates (uni-ui, wot-design-uni), the base template (@dcloudio/*), linting (eslint), TypeScript config (vue-tsc, @vue/tsconfig), and a plugin (@uni-helper/vite-plugin-uni-pages). No code or scripts changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/core/template/base/package.json (1)
66-69: Peer Dependency and Engine Compatibility Verified
- The pinned
@dcloudio/vite-plugin-uni@3.0.0-4070620250821001declares
• peerDependencies:{ "vite": "^5.2.8" }
• engines:{ "node": "^14.18.0 || >=16.0.0" }
which exactly matches the template’s Vite5.2.8and sets a clear Node ≥ 14.18.0 requirement.- No
.nvmrc,.node-version, orenginesfield was found at the repo root.Next steps (recommended):
- Verify that your CI workflows (e.g. GitHub Actions, CircleCI) are using Node ≥ 14.18.0.
- Consider adding an
enginesfield to the rootpackage.json:{ "engines": { "node": ">=14.18.0" } }- Optionally, include a
.nvmrcor.node-versionfile at the project root to lock the Node version for all contributors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
packages/core/template/UI/uni/package.json(1 hunks)packages/core/template/UI/wot/package.json(1 hunks)packages/core/template/base/package.json(1 hunks)packages/core/template/config/lint/package.json(1 hunks)packages/core/template/config/typescript/package.json(1 hunks)packages/core/template/plugin/pages/package.json(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
packages/core/template/UI/wot/package.json (2)
packages/core/template/UI/wot/vite.config.js.data.mjs (2)
plugin(13-13)getData(1-21)packages/core/template/UI/nut/vite.config.js.data.mjs (1)
plugin(23-23)
packages/core/template/base/package.json (1)
packages/info/src/utils/dependencies.ts (2)
getBaseDependencies(3-12)getUniHelperDependencies(14-21)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (--ts, -e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p ...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: test (-e, -p import -p pages -p layouts -p manifest -p filePlatform -p platformModifier -p middle...
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-apple-darwin - node@20
- GitHub Check: stable - i686-pc-windows-msvc - node@20
🔇 Additional comments (5)
packages/core/template/UI/wot/package.json (1)
3-3: Dependency bump to wot-design-uni ^1.12.0 confirmedThe
packages/core/template/UI/wot/package.jsonnow lists only"wot-design-uni": "^1.12.0"— no other dependencies or peer conflicts detected.
Please run a quick scaffold-and-build of the “wot” template to smoke-test component auto-imports and type hints:
- Scaffold a fresh project from the template (e.g.
npx create-wot-app test-wot --template core/template/UI/wot)- In the new project, run
npm install && npm run build- Verify that components are auto-imported correctly and that TypeScript hints resolve as expected
Let me know once the build and type-checking pass successfully.
packages/core/template/config/lint/package.json (1)
8-8: Enforce Node ≥18.18.0 for ESLint v9 compatibility
Add an
"engines"field to each template’spackage.json(includingpackages/core/template/config/lint/package.json) specifying
"node": ">=18.18.0"to guarantee projects generated by our templates run on a Node version supported by ESLint 9 (ESLint v9.0.0+ drops support for Node <18.18.0) (github.com).Update any relevant documentation and template READMEs to call out the new minimum Node.js requirement.
Verify that
@uni-helper/eslint-config@^0.4.0declares ESLint 9.x in itspeerDependencies(e.g."eslint": "^9.0.0"or"eslint": "^8.0.0 || ^9.0.0"), ensuring the config will work with ESLint 9.34.0.packages/core/template/UI/uni/package.json (1)
3-3: Approve uni template dependency bump to @dcloudio/uni-ui ^1.5.11Verified that
packages/core/template/UI/uni/package.json’s dependencies contain only the intended bump to@dcloudio/uni-uiat^1.5.11. No additional changes detected.• Suggest running a quick compile of the “uni” template to confirm there are no new peer-dependency warnings on install.
• All set to merge once the optional compile check is complete.packages/core/template/config/typescript/package.json (1)
7-9: No mismatches detected: TS toolchain centralized inconfig/typescriptAll other templates under
packages/core/templateomit direct TypeScript tooling dependencies, and onlypackages/core/template/config/typescript/package.jsondeclares:
@types/node: ^24.3.0@vue/tsconfig: ^0.8.1typescript: ^5.9.2vue-tsc: ^3.0.6No conflicting pins were found across the rest of the templates. The TypeScript toolchain is already effectively centralized—no further changes are needed here.
packages/core/template/plugin/pages/package.json (1)
3-3: Verify 0.x minor bump in @uni-helper/vite-plugin-uni-pagesOn packages/core/template/plugin/pages/package.json, the dependency was updated from ^0.2.29 to ^0.3.2. Since 0.x minor versions may introduce breaking changes in defaults or options, please review the changelog for versions 0.3.0 through 0.3.2 and adjust the template if needed.
Relevant locations to check:
- packages/core/template/plugin/pages/package.json (dependency version bump)
- packages/core/template/plugin/pages/vite.config.js.data.mjs (importer & initializer for UniPages)
- packages/core/template/plugin/pages/pages.config.js (defineUniPages call)
Diff:
- "@uni-helper/vite-plugin-uni-pages": "^0.2.29" + "@uni-helper/vite-plugin-uni-pages": "^0.3.2"
| "@dcloudio/uni-app": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-app-harmony": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-app-plus": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-components": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-h5": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-alipay": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-baidu": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-harmony": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-jd": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-kuaishou": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-lark": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-qq": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-toutiao": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-weixin": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-mp-xhs": "3.0.0-4070620250821001", | ||
| "@dcloudio/uni-quickapp-webview": "3.0.0-4070620250821001", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Lockstep bump across @dcloudio packages looks good; please verify repo-wide consistency and runtime smoke tests.
- All @dcloudio adapters/framework packages in dependencies are pinned to the same build (3.0.0-4070620250821001), which is what we want for Uni’s tightly-coupled releases.
- Action items:
- Verify every template package.json in this repo uses the exact same @dcloudio build to avoid subtle incompatibilities during scaffolding.
- Run a minimal scaffold + build for at least h5 and one mp target (e.g., weixin) to ensure no regressions with this snapshot build.
Run the following script from the repo root to confirm that all @dcloudio packages across all templates use a single, identical version string:
Optional: consider centralizing this version in a single config for template generation or adding root-level overrides/resolutions to keep @dcloudio packages in lockstep when end-users add plugins later.
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Print all @dcloudio versions found across template package.json files
echo "Scanning @dcloudio versions across templates..."
fd -a package.json packages/core/template | while read -r f; do
jq -r --arg f "$f" '
[.dependencies, .devDependencies]
| map(select(. != null)) | add // {}
| to_entries
| map(select(.key | startswith("@dcloudio/")))
| .[]
| "\($f)\t\(.key)\t\(.value)"
' "$f"
done | tee /tmp/dcloudio_versions.tsv
echo
echo "Distinct version strings used:"
cut -f3 /tmp/dcloudio_versions.tsv | sort -u
echo
echo "Fail if more than one distinct version is present:"
distinct_count=$(cut -f3 /tmp/dcloudio_versions.tsv | sort -u | wc -l | tr -d ' ')
if [ "$distinct_count" -ne 1 ]; then
echo "ERROR: Multiple @dcloudio version strings detected across templates." >&2
exit 1
else
echo "OK: Single @dcloudio version string detected across all templates."
fiLength of output: 1698
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
declare -A versions
echo "Scanning @dcloudio versions across template package.json files..."
find packages/core/template -type f -name package.json | while read -r f; do
jq -r '.dependencies + .devDependencies
| to_entries[]
| select(.key | startswith("@dcloudio/"))
| "\(.key)\t\(.value)"' "$f" \
| while IFS=$'\t' read -r key ver; do
echo "$f $key $ver"
versions["$ver"]=1
done
done
echo
echo "Distinct version strings used:"
printf "%s\n" "${!versions[@]}" | sort
count=${#versions[@]}
if [ "$count" -ne 1 ]; then
echo
echo "ERROR: Multiple @dcloudio version strings detected across templates." >&2
exit 1
else
echo
echo "OK: Single @dcloudio version string detected across all templates."
fiLength of output: 10692
@dcloudio version mismatch across templates
It looks like most of your templates have been bumped to the 3.0.0-4070620250821001 snapshot, but the UI template for “uni” is still pinning @dcloudio/uni-ui at ^1.5.11. To preserve the lockstep bump (and avoid subtle runtime or scaffolding mismatches), you’ll need to align that and any other outliers:
• packages/core/template/UI/uni/package.json
- Currently:
"@dcloudio/uni-ui": "^1.5.11" - Should be:
"@dcloudio/uni-ui": "3.0.0-4070620250821001"
• After fixing, re-run the scan across packages/core/template/**/package.json to confirm a single @dcloudio/* version string everywhere.
• Then run minimal scaffolds+builds (e.g. H5 and Weixin) to smoke-test the snapshot.
--- packages/core/template/UI/uni/package.json
@@ dependencies
- "@dcloudio/uni-ui": "^1.5.11",
+ "@dcloudio/uni-ui": "3.0.0-4070620250821001",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@dcloudio/uni-app": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-app-harmony": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-app-plus": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-components": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-h5": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-alipay": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-baidu": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-harmony": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-jd": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-kuaishou": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-lark": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-qq": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-toutiao": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-weixin": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-mp-xhs": "3.0.0-4070620250821001", | |
| "@dcloudio/uni-quickapp-webview": "3.0.0-4070620250821001", | |
| --- packages/core/template/UI/uni/package.json | |
| @@ dependencies | |
| "@dcloudio/uni-ui": "3.0.0-4070620250821001", |
🤖 Prompt for AI Agents
In packages/core/template/base/package.json lines 45-60, the repo bumped most
@dcloudio packages to the 3.0.0-4070620250821001 snapshot but the UI template
(packages/core/template/UI/uni/package.json) still pins "@dcloudio/uni-ui":
"^1.5.11"; update that entry to "@dcloudio/uni-ui": "3.0.0-4070620250821001",
then run a quick grep/scan across packages/core/template/**/package.json to
ensure all @dcloudio/* entries share the exact snapshot string and fix any
remaining outliers, and finally run minimal scaffolds and builds (e.g., H5 and
Weixin) to smoke-test the snapshot.
Update dependencies
Summary by CodeRabbit