Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala 2.13, remove support for Scala 2.10 #72

Closed
DaniRey opened this issue Mar 6, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@DaniRey
Copy link
Member

commented Mar 6, 2019

Scala 2.13 will be released soon, ScalaTest is already cross-compiled for 2.13.

It is a good point in time to add support for 2.13 and remove 2.10.

Simultaneously we can (Java libraries) and or have to (Scala libraries) upgrade all dependencies.

As soon as we have a stable version, we can relase a release candidate, and then short after Scala 2.13 is released the final ScalaWebTest 3.0.0 release.

@DaniRey DaniRey added this to the 3.0.0 milestone May 29, 2019

@DaniRey DaniRey changed the title Upgrade all dependencies Add support for Scala 2.13, remove 2.10 May 31, 2019

@DaniRey DaniRey changed the title Add support for Scala 2.13, remove 2.10 Add support for Scala 2.13, remove support for Scala 2.10 May 31, 2019

DaniRey added a commit that referenced this issue May 31, 2019

Add support for Scala 2.13, remove support for Scala 2.10 #72
  - compile against Scala 2.12.8 instead of 2.12.7
  - add Scala 2.13.0-RC3
  - remove Scala 2.10.7
  - keep default Scala version at 2.12.x because of https://youtrack.jetbrains.com/issue/SCL-15558
  - upgrade ScalaTest dependency to 3.0.8-RC5
  - upgrade Selenium to 3.141.59
  - upgrade HtmlUnit to 2.35.1
  - upgrade slf4j to 1.7.26
  - upgrade play-json to 2.8.0-M1 for Scala 2.13 and 2.12
  - upgrade play-json to 2.7.0 for Scala 2.11.x (as version 2.8.0-M1 is not available for 2.11.x)
  - upgrade sbt from 0.13.16 to 0.13.18 (intermediate step before Update to SBT 1.0 - #75)
  - getting rid of procedure syntax (f(): Unit = {} instead of f(){}), because it is deprecated with 2.13
  - replace .fold with .mkString, because it is simpler and because of scala/bug#11550 (which is not a bug, just a change in behavior)

DaniRey added a commit that referenced this issue May 31, 2019

Add support for Scala 2.13, remove support for Scala 2.10 #72
  - compile against Scala 2.12.8 instead of 2.12.7
  - add Scala 2.13.0-RC3
  - remove Scala 2.10.7
  - keep default Scala version at 2.12.x because of https://youtrack.jetbrains.com/issue/SCL-15558
  - upgrade ScalaTest dependency to 3.0.8-RC5
  - upgrade Selenium to 3.141.59
  - upgrade HtmlUnit to 2.35.1
  - upgrade slf4j to 1.7.26
  - upgrade play-json to 2.8.0-M1 for Scala 2.13 and 2.12
  - upgrade play-json to 2.7.0 for Scala 2.11.x (as version 2.8.0-M1 is not available for 2.11.x)
  - upgrade sbt from 0.13.16 to 0.13.18 (intermediate step before Update to SBT 1.0 - #75)
  - getting rid of procedure syntax (f(): Unit = {} instead of f(){}), because it is deprecated with 2.13
  - replace .fold with .mkString, because it is simpler and because of scala/bug#11550 (which is not a bug, just a change in behavior)

DaniRey added a commit that referenced this issue May 31, 2019

Update to SBT 1.x #75
 - update from sbt 0.13.18 to sbt 1.2.8
 - thanks to "remove support for Scala 2.10" #72, we can get rid of the 2.11+ folders and crossVersionSharedSources function
@DaniRey

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

We will keep this ticket open until 2.13.0 is released, then update all dependencies accordingly and release ScalaWebTest 3.0.0

DaniRey added a commit that referenced this issue Jun 11, 2019

Add support for Scala 2.13, remove support for Scala 2.10 #72
 - final release of Scala 2.13 is ready
 - as soon as play-json_2.13 is available we can release ScalaWebTest 3.0.0

DaniRey added a commit that referenced this issue Jun 11, 2019

Add support for Scala 2.13, remove support for Scala 2.10 #72
 - reverting default Scala version to 2.12, beacuse https://youtrack.jetbrains.com/oauth?state=%2Fissue%2FSCL-15558 is not yet available, and running tests from the IDE is convenient

DaniRey added a commit that referenced this issue Jun 13, 2019

Add support for Scala 2.13, remove support for Scala 2.10 #72
 - play-json version 2.7.4 has been cross-released for all Scala versions that are relevant to us (2.11, 2.12 and 2.13), therefore we can simplify our build a lot

DaniRey added a commit that referenced this issue Jun 14, 2019

Merge pull request #88 from marcospereira/updates/play-json-2.7.4
- Add support for Scala 2.13, remove support for Scala 2.10 #72
- Update play-json version to 2.7.4
- Add chromedriver as a requirement in the readme
- Fix markdown in readme

@DaniRey DaniRey closed this Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.