Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log viewer: toggeling "follow" does not stop the log tail #287

Closed
olaf-otto opened this Issue Jan 15, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@olaf-otto
Copy link
Member

olaf-otto commented Jan 15, 2019

Activating and subsequently deactivating the "follow" option in the log viewer does not stop the log tail. It seems the websocket is no longer closed.

@olaf-otto olaf-otto added the bug label Jan 15, 2019

@olaf-otto olaf-otto added this to the 5.0.3 milestone Jan 15, 2019

@olaf-otto olaf-otto self-assigned this Jan 15, 2019

olaf-otto added a commit that referenced this issue Jan 17, 2019

#287 Log viewer: toggeling "follow" does not stop the log tail
#288 Log viewer: Introduce filtering by typing in logfiles dropdown

olaf-otto added a commit that referenced this issue Jan 17, 2019

#287 Log viewer: toggeling "follow" does not stop the log tail
#288 Log viewer: Introduce filtering by typing in logfiles dropdown

Increased test coverage and removed unused mocks

olaf-otto added a commit that referenced this issue Jan 17, 2019

Merge pull request #289 from unic/neba-287
#287 Log viewer: toggeling "follow" does not stop the log tail
@olaf-otto

This comment has been minimized.

Copy link
Member Author

olaf-otto commented Jan 17, 2019

Fixed

@olaf-otto olaf-otto closed this Jan 17, 2019

olaf-otto added a commit that referenced this issue Mar 14, 2019

#287 Log viewer: toggeling "follow" does not stop the log tail
#288 Log viewer: Introduce filtering by typing in logfiles dropdown

olaf-otto added a commit that referenced this issue Mar 14, 2019

#287 Log viewer: toggeling "follow" does not stop the log tail
#288 Log viewer: Introduce filtering by typing in logfiles dropdown

Increased test coverage and removed unused mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.