Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify an application bundles autostart setting when stopping a bundle when the spring application context fails #296

Closed
olaf-otto opened this Issue Feb 14, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@olaf-otto
Copy link
Member

olaf-otto commented Feb 14, 2019

When using NEBA with Spring, NEBA registers a ContextShutdownHandler that will stop a bundle who's Spring Application Handler failed to start. This is rather useful as otherwise the bundle remains Active and it becomes hard to spot that a bundle exhibited a failure of part of its infrastructure.

The current implementation stops the bundle by invoking Bundle#stop(). This however persists the bundle's autostart setting. That is, the framework will not automatically try to re-start the bundle when the framework restarts.

This is an issue in case there is nothing to resolve, e.g. when the Application Context Failure was temporary. For instance, it may be that a framework restart is issued while an application context is in the process of starting, thus leading to a context start failure. Subsequently, the app bundle has to be re-started manually.

Here, the bundle state must not be persisted, i.e. Bundle#stop must be invoked with a suitable argument.

@olaf-otto olaf-otto added this to the Roadmap milestone Feb 14, 2019

@olaf-otto olaf-otto self-assigned this Feb 14, 2019

olaf-otto added a commit that referenced this issue Feb 14, 2019

#296 Do not modify an application bundles autostart setting when stop…
…ping a bundle when the spring application context fails

olaf-otto added a commit that referenced this issue Feb 15, 2019

Merge pull request #297 from unic/neba-296
#296 Do not modify an application bundles autostart setting when stop…
@olaf-otto

This comment has been minimized.

Copy link
Member Author

olaf-otto commented Feb 15, 2019

Done

@olaf-otto olaf-otto closed this Feb 15, 2019

@olaf-otto olaf-otto modified the milestones: Roadmap, 5.0.4 Feb 15, 2019

olaf-otto added a commit that referenced this issue Mar 14, 2019

#296 Do not modify an application bundles autostart setting when stop…
…ping a bundle when the spring application context fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.