Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent potential race condition in model registration #305

Closed
olaf-otto opened this Issue Mar 26, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@olaf-otto
Copy link
Member

olaf-otto commented Mar 26, 2019

NEBA calculates a set of metadata dor each resource model when it is registered. This metadata is required to map resources to the model as it holds all mapping information that can be calculated in advance.

During registration, we used to rely on the single-threaded handling by the context factory to the extend that the respective registration was not made explicitly thread-safe. With the changes since NEBA 5.0, it is possible (albeit not likely) that resoure model sources (factories) are discovered concurrently.

Thus, we need to ensure the registration of the models is thread-safe.

@olaf-otto olaf-otto added the bug label Mar 26, 2019

@olaf-otto olaf-otto added this to the 5.0.5 milestone Mar 26, 2019

olaf-otto added a commit that referenced this issue Mar 26, 2019

olaf-otto added a commit that referenced this issue Mar 26, 2019

Merge pull request #306 from unic/neba-305
#305 Prevent potential race condition in model registration
@olaf-otto

This comment has been minimized.

Copy link
Member Author

olaf-otto commented Mar 26, 2019

Fixed!

@olaf-otto olaf-otto closed this Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.