Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the resource resolver principal as a cache key may improve Neba's request-scoped resource model cache hit ratio #376

Closed
olaf-otto opened this issue Jan 29, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@olaf-otto
Copy link
Member

@olaf-otto olaf-otto commented Jan 29, 2020

To ensure that the request-scoped resource model cache does not leak privileges, the identity of the resource resolver used to obtain a model instance is used as part of the cache key. However, the identity of the instance may change within the same request even if the resource resolver privileges remain unchanged. For instance, multiple resolver instances may be opened and closed for the same user.

Here, using the principal name associated with the resource resolver instead of the resolver's object ID may improve the hit/miss ratio.

@olaf-otto olaf-otto added this to the 5.1.3 milestone Jan 29, 2020
@olaf-otto olaf-otto self-assigned this Jan 29, 2020
olaf-otto added a commit that referenced this issue Jan 30, 2020
… Neba's request-scoped resource model cache hit ratio
olaf-otto added a commit that referenced this issue Jan 30, 2020
… Neba's request-scoped resource model cache hit ratio
olaf-otto added a commit that referenced this issue Jan 30, 2020
#376 Using the resource resolver principal as a cache key may improve…
@olaf-otto

This comment has been minimized.

Copy link
Member Author

@olaf-otto olaf-otto commented Jan 30, 2020

Implemented, done!

@olaf-otto olaf-otto closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.