Skip to content

Develop#4

Merged
orioltf merged 4 commits into
mainfrom
develop
Apr 30, 2026
Merged

Develop#4
orioltf merged 4 commits into
mainfrom
develop

Conversation

@orioltf

@orioltf orioltf commented Apr 30, 2026

Copy link
Copy Markdown
Member

No description provided.

orioltf and others added 4 commits April 30, 2026 17:40
Adds docs/plans/15-release-tools-tests.md for bump-version and
sync-version test coverage, registers it in the execution table,
and introduces a ## Backlog section in the roadmap for ideas not
yet ready for Ralph.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Status: "in progress" → "open" (spec is ready for Ralph, not in-flight)
- Verification comment: macOS-only → CI validates all three platforms
- Date criterion: "today's date" → assert YYYY-MM-DD format (no wall-clock dependency)
- Keywords: add to mirrors acceptance criterion (matches MIRRORED_FIELDS in sync-version.mjs)
- Add missing bump-version criteria: malformed version, missing [Unreleased] section
- Add missing sync-version criterion: .version missing/non-string in plugin.json
- Implementation step 1: add cwd + fake-git + marketplace.json fixture guidance

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…conflict

- Step 1: explicit cross-platform stubs (git + git.cmd) and path.delimiter

- Out of scope: remove Windows-contradicting item; clarify shared-helper  abstraction is out of scope, not platform coverage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chore(spec-15): add spec and roadmap backlog section
@orioltf orioltf merged commit 823ec31 into main Apr 30, 2026
7 checks passed
orioltf added a commit that referenced this pull request Jun 2, 2026
…in lockfiles

Prevent recurrence of the orphaned pnpm-lock.yaml pattern that caused
Dependabot alerts #4 and #5 (fixed in PR #174).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
orioltf added a commit that referenced this pull request Jun 9, 2026
A --post retry where the Review Summary failed in the prior attempt could
silently drop it (all inline Threads already posted → pruned approved set is
empty → Writer's zero-Findings short-circuit skips Step 3) or render it from
the reduced re-post subset (some inline failed → incomplete Summary). Both
violate ADR-0015 AC#1 ("posts the Summary only if it didn't already land").

Why: a single approvedPath fed both the inline Threads (Step 2) and the
Summary (Step 3a), so pruning it for inline dedup corrupted the Summary.

Fix: stop pruning the approved set. The orchestrator now keeps APPROVED_FILE
full and passes the Writer an alreadyPostedFindingIds inline-skip list; the
Writer skips those inline Threads but still renders the Summary from every
approved Finding. Replaces filterUnposted/the `filter` subcommand with
postedFindingIds/`posted-ids`. Amends ADR-0015 decision #4 accordingly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant