Skip to content

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented May 7, 2025

CLDR-4681

  • Escape the English column

  • Change the escaping bracket to match usage elsewhere (heavy brackets)

  • link to more info when hovering over

  • show U+ hex always

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Review Notes

English escaped

image

Hovering over the box highlights the (i) and explains the box

image

Items toggle color and show detail when hovered

image

'unknown' (in this case PUA) shown

image

srl295 added 2 commits May 7, 2025 15:17
- highlight the escapes when hovering
- show the hex number (U+202F) always
@srl295 srl295 self-assigned this May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

✨ deployed to https://0242ef4e.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label May 7, 2025
@srl295 srl295 requested a review from AEApple May 7, 2025 21:15
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some changes, but approving in case you want to get this updated today.


### Special Characters

Some items may use special characters, especially invisible characters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should align this and the info hub changes. Can be done after merging.

}
.data .visible-mark::before{
content: '<';
content: '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downside of having this not in the text is that people can't search on page for it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with other one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's to make the display more flexible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. But people can't search for it. And the slight advantage of our being able to update with a CSS change instead of a code change isn't worth sacrificing that.

However, in the code they can be constants, so it is easy to change in one place.

@srl295 srl295 merged commit 5dd142c into main May 7, 2025
20 checks passed
@srl295 srl295 deleted the srl295/cldr-16765/escape-english branch May 7, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Site Update Updates docs/site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants