-
Notifications
You must be signed in to change notification settings - Fork 411
CLDR-16765 escape English column, link to docs #4682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- highlight the escapes when hovering - show the hex number (U+202F) always
|
✨ deployed to https://0242ef4e.cldr.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some changes, but approving in case you want to get this updated today.
|
|
||
| ### Special Characters | ||
|
|
||
| Some items may use special characters, especially invisible characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should align this and the info hub changes. Can be done after merging.
| } | ||
| .data .visible-mark::before{ | ||
| content: '<'; | ||
| content: '❰'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside of having this not in the text is that people can't search on page for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's to make the display more flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. But people can't search for it. And the slight advantage of our being able to update with a CSS change instead of a code change isn't worth sacrificing that.
However, in the code they can be constants, so it is easy to change in one place.
CLDR-4681
Escape the English column
Change the escaping bracket to match usage elsewhere (heavy brackets)
link to more info when hovering over
show U+ hex always
This PR completes the ticket.
ALLOW_MANY_COMMITS=true
Review Notes
English escaped
Hovering over the box highlights the (i) and explains the box
(i)goes to https://cldr.unicode.org/translation/getting-started/guide#special-characters - updated in this PRItems toggle color and show detail when hovered
'unknown' (in this case PUA) shown