Skip to content

CLDR-18682 Make sure Dashboard is displayed if wanted when page is reloaded #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

CLDR-18682 Make sure Dashboard is displayed if wanted when page is reloaded #4753

merged 1 commit into from
May 29, 2025

Conversation

@btangmu
Copy link
Member

@btangmu btangmu commented May 29, 2025

-Call cldrDashContext.insert from cldrGui.completeStartupWithSession if appropriate

-Calling cldrDashContext.insert redundantly (when already visible) is harmless

CLDR-18682

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@btangmu
CLDR-18682 Make sure Dashboard is displayed if wanted when page is re…
c7e77eb 
…loaded

-Call cldrDashContext.insert from cldrGui.completeStartupWithSession if appropriate

-Calling cldrDashContext.insert redundantly (when already visible) is harmless
@btangmu btangmu self-assigned this May 29, 2025
@btangmu btangmu requested a review from srl295 May 29, 2025 00:27
srl295
srl295 approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is what was making it not show in the web driver?

@btangmu
Copy link
Member Author

btangmu commented May 29, 2025

Do you think this is what was making it not show in the web driver?

I'm wondering the same thing! Maybe we'll find out...

@btangmu
Copy link
Member Author

btangmu commented May 29, 2025

Do you think this is what was making it not show in the web driver?

I'm wondering the same thing! Maybe we'll find out...

Maybe so, if surveydriver doesn't go through the left-side menu to choose a locale, but just chooses it implicitly in the URL.

@btangmu btangmu merged commit 67c6996 into unicode-org:main May 29, 2025
16 checks passed
@btangmu btangmu deleted the t18682_a branch May 29, 2025 00:52
@srl295
Copy link
Member

srl295 commented May 29, 2025

Do you think this is what was making it not show in the web driver?

I'm wondering the same thing! Maybe we'll find out...

Maybe so, if surveydriver doesn't go through the left-side menu to choose a locale, but just chooses it implicitly in the URL.

oh so you mean going through the left side was required to set up the mechanism?

@btangmu
Copy link
Member Author

btangmu commented May 29, 2025

oh so you mean going through the left side was required to set up the mechanism?

Not necessarily. There are various circumstances in which the dashboard gets opened... hard to generalize...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 approved these changes

Assignees

@btangmu btangmu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@btangmu @srl295