ICU-20308 Define a fixed suffix without the ICU version suffix #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvictor
force-pushed
the
fixed_suffix
branch
from
0bdbb81
to
69d6e8f
Compare
gvictor
changed the title
markusicu
requested changes
Dec 11, 2018
srl295
previously requested changes
Dec 11, 2018
gvictor
force-pushed
the
fixed_suffix
branch
from
69d6e8f
to
f74f5f5
Compare
markusicu
requested changes
Dec 12, 2018
- Add a config macro U_DISABLE_VERSION_SUFFIX to disable version suffix
gvictor
force-pushed
the
fixed_suffix
branch
from
f74f5f5
to
9191e3d
Compare
gvictor
dismissed
srl295’s stale review
I have address the comment by markus, and added the doc.
|
Not authorized to merge this PR. Could someone help? |
|
I sent Steven a chat message asking if he wants further changes, wants to approve, or is ok with me to dismiss his request for changes. I want to give him some time before I dismiss & merge. |
srl295
approved these changes
Dec 13, 2018
|
Thanks, Markus and Steven! |
|
merged. please close the ticket, and probably delete your branch. |
|
This change causes a build breakage on some Chrome builds. Enabling |
BoredOutOfMyGit
pushed a commit
to codeaurora-unofficial/platform-external-icu
that referenced
this pull request
Dec 29, 2019
…n suffix The upstream change is pending review. unicode-org/icu#308 Bug: 117094880 Test: m Change-Id: If71ba334f13947969335fd6538c0301cf753c7ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config macro U_DISABLE_VERSION_SUFFIX to disable version suffix
Issue filed: https://unicode-org.atlassian.net/browse/ICU-20308
Updated PR title and link in previous line to include Issue number
Issue accepted
Tests included
Documentation is changed or added