Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-20664 Add CI builds that exercise the Data Filtering. #686

Merged
merged 1 commit into from Jun 14, 2019

Conversation

jefgen
Copy link
Member

@jefgen jefgen commented Jun 12, 2019

This adds two extra CI builds to exercise the Data Filtering on Linux with Clang and on Windows with MSVC.

Notes:
I'm only using the simple example file from the ICU Data Build Tool document for now, and adding it to the .ci-builds sub-folder.
We could move it somewhere else if you wanted, or use more advanced data filtering -- this is mainly just to have CI build coverage for now.
Also, these builds don't run any tests, as the reduced data bundle would cause test failures.

Checklist

axelandrejs
axelandrejs previously approved these changes Jun 12, 2019
sffc
sffc previously approved these changes Jun 12, 2019
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thanks!

The initial data-filter.json is rather simple, but now we can follow up on a case-by-case basis to add more conditions to exercise more code paths.

@jefgen jefgen dismissed stale reviews from sffc and axelandrejs via bfc69d1 June 13, 2019 01:21
@jefgen jefgen force-pushed the jefgen/data-filters-CI-builds branch from 2a91b3d to bfc69d1 Compare June 13, 2019 01:21
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .ci-builds/.azure-pipelines.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jefgen
Copy link
Member Author

jefgen commented Jun 13, 2019

Ah, I realized that I didn't change the display name on the Clang build.
It still said "Build and Test".
I force-pushed a small update to change it to "Build with Data Filter"

@jefgen jefgen merged commit 506c935 into unicode-org:master Jun 14, 2019
@jefgen jefgen deleted the jefgen/data-filters-CI-builds branch June 14, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants