New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Numeric PdfVersion #228

Closed
wants to merge 1 commit into
base: v3-enhance-forms
from

Conversation

Projects
None yet
2 participants
@iamacarpet

iamacarpet commented Oct 4, 2018

Would it be ok to expose the PdfVersion to easily copy to the destination document?

https://github.com/a1comms/pdf-api/blob/cf11daa9c35c2dc88eebc06b12ccffab33db4d1b/model_pdf_merge.go#L38

@gunnsth

This comment has been minimized.

Show comment
Hide comment
@gunnsth

gunnsth Oct 5, 2018

Contributor

Thanks, that is a good point. I propose to do it slightly differently as proposed in #230

Contributor

gunnsth commented Oct 5, 2018

Thanks, that is a good point. I propose to do it slightly differently as proposed in #230

@iamacarpet

This comment has been minimized.

Show comment
Hide comment
@iamacarpet

iamacarpet Oct 5, 2018

Sounds loads better, I'll close this PR.

iamacarpet commented Oct 5, 2018

Sounds loads better, I'll close this PR.

@iamacarpet iamacarpet closed this Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment