Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to parse invalid beginning lines of xref table subsections. #91

Merged
merged 1 commit into from Jun 14, 2019
Merged

Attempt to parse invalid beginning lines of xref table subsections. #91

merged 1 commit into from Jun 14, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jun 13, 2019

Addresses #4


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #91 into development will decrease coverage by 5.13%.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #91      +/-   ##
===============================================
- Coverage        60.16%   55.02%   -5.14%     
===============================================
  Files              154      154              
  Lines            27985    27993       +8     
===============================================
- Hits             16836    15404    -1432     
- Misses           10764    10765       +1     
- Partials           385     1824    +1439
Impacted Files Coverage Δ
core/parser.go 68.33% <75%> (-8.14%) ⬇️
internal/e2etest/utils.go 60% <0%> (-20%) ⬇️
ps/exec.go 62.96% <0%> (-18.52%) ⬇️
core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
model/signature_handler.go 55.04% <0%> (-15.6%) ⬇️
model/reader.go 50.84% <0%> (-14.22%) ⬇️
ps/operations.go 53.45% <0%> (-13.68%) ⬇️
core/stream.go 31.08% <0%> (-13.52%) ⬇️
extractor/image.go 65.51% <0%> (-12.94%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d343...9dec1cd. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 2daa144 into unidoc:development Jun 14, 2019
@adrg adrg deleted the xref-table-invalid-line branch June 17, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants