-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to control message with position(1:1) #4
Comments
So first of all, I believe this message should in fact be about Otherwise: I think it makes sense! |
@wooorm You referred to another line(#L20). My example is #L15. :) |
@chinesedfan Yeah I know, but I just saw it anyway and wanted to mention it ;) |
@wooorm OK, thanks for your finding and I will notify sindresorhus/awesome-lint. Let's back to this issue. Should this package consider messages that belong to the whole file? If yes, how can we control them? |
Yep, I think sosee my earlier comment: “I think it makes sense!”
It’s been a while since I’ve delved into this code! Maybe we can change unified-message-control/index.js Lines 131 to 139 in 4d6f75e
|
The current
check
logic requires the message position should be after the mark begin. It is reasonable in most cases.But if a message belongs to the whole file, like missing license, we can't declare a mark more before than 1:1(line:column).
The text was updated successfully, but these errors were encountered: