-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove poll/select and eventfd stubs #23
Remove poll/select and eventfd stubs #23
Conversation
This commit removes the stubs for functions provided by the new posix-socket and posix-event libraries. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
All good here 👍 Waiting for more approval before adding the tag |
Hi, @marcrittinghaus, this is my first pass. It seems OK, I have some questions: Why were the What was the initial purpose of including the Does it make sense to still have the |
@razvand If you look at the history of the file you see that I once required all these definitions and headers. Over time more and more stubs were removed but these definitions remained.
Looking at the man page |
@marcrittinghaus , all is OK. @craciunoiuc , please approve this PR and then I'll approve it as well. I'll be careful to do the approval in the order signaled by @marcrittinghaus . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my side!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @marcrittinghaus . This works.
Reviewed-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
Approved-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
This commit removes the stubs for functions provided by the new posix-socket and posix-event libraries. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Approved-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #23
This commit removes the stubs for functions provided by the new posix-socket and posix-event libraries.
This PR is part of a larger group of dependent PRs which must be merged in the following order: