Remove mandatory dependency on ipv6 support #7
Conversation
Given the fact that redis works well without having the ipv6 support selected, this commit removes the mandatory dependency, enabling better testing with libraries that currently do not support ipv6 (eg. musl). Signed-off-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
mariasfiraiala
force-pushed
the
remove-ipv6-dependency
branch
from
aebe903
to
4fbb7b0
Compare
There was a problem hiding this comment.
Did the build work for you without ipv6 enabled @mariasfiraiala?
I get some undefined symbols errors from the lib-redis origin anet.c source file
(e.g. INET6_ADDRSTRLEN, sockaddr_in6, IPPROTO_IPV6).
Yes, I've built |
Got it, I was using |
There was a problem hiding this comment.
newlib needs ipv6 enabled, but this work fine with musl, and since we
will give up on newlib I think this can be merged.
Thank you @mariasfiraiala.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
|
Hi, @mariasfiraiala , @StefanJum . We have Musl working with IPv6. So I will close this PR. |
Given the fact that
redisworks well without having the ipv6 support selected, this PR removes the mandatory dependency, enabling better testing with libraries that currently do not support ipv6 (eg.musl).Signed-off-by: Maria Sfiraiala maria.sfiraiala@gmail.com