This repository was archived by the owner on Jul 17, 2023. It is now read-only.
plat/volume: Set volume driver to Enum instance#72
Merged
razvand merged 1 commit intounikraft:stagingfrom Mar 17, 2022
Merged
Conversation
razvand
added
the
area/plat
StefanJum
approved these changes
Jan 8, 2022
Member
There was a problem hiding this comment.
Looks good, fixed issue #71 for me.
OS: Ubuntu 20.04.1
kraft staging version 0.5.0.dev477
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Member
|
Hi @razvand, this PR needs to be rebased before it can be merged :) |
Checks for drivers are made against `VolumeDriver` Enum instances. Update the implementation of `Volume` class to use `VolumeDriver` Enum instances for the `_driver` member of the class. In turn, this fixes issue unikraft#71 on mounting 9PFS filesystems. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
razvand
force-pushed
the
use-volume-driver-as-enum
branch
from
951c412 to
b292ddc
Compare
Contributor
Author
|
@nderjung , fixed. This is now rebased and ready to be merged. It will save quite a bit of headaches. |
Contributor
Author
|
@nderjung , reminder to have this fix merged if it's OK with you. @StefanJum reviewed it. I can merge it myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for drivers are made against
VolumeDriverEnum instances. Update the implementation ofVolumeclass to useVolumeDriverEnum instances for the_drivermember of the class.In turn, this fixes issue #71 on mounting 9PFS filesystems.