lib/uknetdev: Define and implement burst transactions for netdevice

[hisharanwithu]

This patch series enables batching the send/receive operation on
a network packets on a netdev. The implementation extends the
virtio-net driver to support batch operation.

• plat/virtio: Remove warning in virtio_netdev_recv
• lib/uknetdev: Support burst tx
• lib/uknetdev: Support to check UK_NETDEV_UNDERRUN status
• lib/uknetdev: Support burst receive
• plat/virtio: Support ANY_LAYOUT on virtio_net
• lib/uknetdev: Release a burst of packet from ring

[unikraft-bot]

⚠️ Checkpatch passed with warnings

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request but it encountered warnings:

SHA	commit	checkpatch
f6115a3	plat/virtio: Remove warning in virtio_netdev_recv	✅
995a704	lib/uknetdev: Support burst tx	✅
31de5c7	lib/uknetdev: Support to check UK_NETDEV_UNDERRUN status	✅
a1569a0	lib/uknetdev: Support burst receive	⚠️
8702620	plat/virtio: Support ANY_LAYOUT on virtio_net	⚠️
2bf0cdc	lib/uknetdev: Release a burst of packet from ring	✅

Truncated logs starting from first warning a1569a0:

WARNING:LONG_LINE_STRING: line over 80 characters
#314: FILE: plat/drivers/virtio/virtio_net.c:324:
+			uk_pr_debug("Enqueue netbuf %"PRIu16"/%"PRIu16" (%p) to virtqueue %p write_cnt: %d...\n",

total: 0 errors, 1 warnings, 590 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/build/a53d4c5b/patches/0004-lib-uknetdev-Support-burst-receive.patch has style problems, please review.

NOTE: Ignored message types: ASSIGN_IN_IF FILE_PATH_CHANGES NEW_TYPEDEFS OBSOLETE

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

---

View complete logs | Learn more about Unikraft's coding style and contribution guidelines.

[Zack-Will]

I see that netdevice supports burst in earlier versions, why was this feature removed?

[razvand]

I see that netdevice supports burst in earlier versions, why was this feature removed?

@skuenzer, could you answer this?

[skuenzer]

I see that netdevice supports burst in earlier versions, why was this feature removed?

Hi @Zack-Will,
in fact, burst behavior was never upstream but planned for uknetdev. We planned to update this PR with a slight different API, however, we did not manage to do so yet because of different priorities. On the other hand, you also need networking stacks supporting bursts, the use is limited to custom network functions. Are you interested in such a functionality?

Thanks,

Simon